Enhancement/http_req #299
Merged
Enhancement/http_req #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very good work! I will add a couple of comments inline. |
| @@ -314,6 +325,10 @@ def errback(failure, request): | |||
| self.addToReport(request, failure_string=failure_string) | |||
| return failure | |||
|
|
|||
| if use_tor: | |||
| state = config.tor_state | |||
| state.add_stream_listener(StreamListener(request)) | |||
There was a problem hiding this comment.
This probably needs to be conditional as it is possible that the user has configured their ooni-probe without a control port and tor was not started by us. In that case we can't do very much, but we should at least not fail badly.
| if use_tor: | ||
| state = config.tor_state | ||
| if state: | ||
| state.add_stream_listener(StreamListener(request)) |
There was a problem hiding this comment.
Condition added
|
Ok this looks good, merging, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81